[HW] Add hw.triggered op
#5582
Merged
[HW] Add hw.triggered op
#5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's a stab at the `hw.triggered` operation.
I think the main issue is to decide where to place the lowering. AFAICT, the closest we have to a "hw to sv" conversion pass is `hw-legalize-modules` (which really should be named to `sv-legalize-modules` seeing as it's lowering away HW constructs in favor of SV constructs).
I chose to introduce a new pass - `lower-hw-to-sv` which could serve as a clear home for these kinds of lowerings (maybe some things in `HWLegalizeModules` could be moved to here?).
Lastly, just went with a simple assembly format. If people would like to see something more fancy, e.g. an initializer-list style format with an elided entry block:
> `hw.triggered postedge %t (%a0 : i32 = %in) { ...`
let me know.
teqdruid
approved these changes
Jul 14, 2023
| def AtPosEdge: I32EnumAttrCase<"AtPosEdge", 0, "posedge">; | ||
| /// AtNegEdge triggers on a drop from 1 to 0/X/Z, or X/Z to 0. | ||
| def AtNegEdge: I32EnumAttrCase<"AtNegEdge", 1, "negedge">; | ||
| /// AtEdge(v) is syntactic sugar for "AtPosEdge(v) or AtNegEdge(v)". |
There was a problem hiding this comment.
I don't think it's just syntactic sugar so much as the only way to specify this behavior.
|
|
||
| let regions = (region SizedRegion<1>:$body); | ||
| let arguments = (ins EventControlAttr:$event, I1:$trigger, Variadic<AnyType>:$inputs); | ||
| let results = (outs); |
There was a problem hiding this comment.
We may want results in the future, but let's add it when we have a use case.
fabianschuiki
approved these changes
Jul 14, 2023
Comment on lines
+25
to
+35
| static sv::EventControl hwToSvEventControl(hw::EventControl ec) { | ||
| switch (ec) { | ||
| case hw::EventControl::AtPosEdge: | ||
| return sv::EventControl::AtPosEdge; | ||
| case hw::EventControl::AtNegEdge: | ||
| return sv::EventControl::AtNegEdge; | ||
| case hw::EventControl::AtEdge: | ||
| return sv::EventControl::AtEdge; | ||
| } | ||
| llvm_unreachable("Unknown event control kind"); | ||
| } |
There was a problem hiding this comment.
Now that we have EventControl in HW, we might be able to replace all other dialect-local EventControl things with the HW flavor! I think I've seen a few dialects where we redefine that enum.
There was a problem hiding this comment.
Captured in #5601.
Comment on lines
+3
to
+11
| hw.module @foo(%trigger : i1, %in : i32) { | ||
| // CHECK: sv.always posedge %trigger { | ||
| // CHECK-NEXT: "some.user"(%in) : (i32) -> () | ||
| // CHECK-NEXT: } | ||
| hw.triggered posedge %trigger (%in) : i32 { | ||
| ^bb0(%arg0 : i32): | ||
| "some.user" (%arg0) : (i32) -> () | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a stab at #5574.
I think the main issue is to decide where to place the lowering. AFAICT, the closest we have to a "hw to sv" conversion pass is
hw-legalize-modules(which really should be named tosv-legalize-modulesseeing as it's lowering away HW constructs in favor of SV constructs). I chose to introduce a new pass -lower-hw-to-svwhich could serve as a clear home for these kinds of lowerings (maybe some things inHWLegalizeModulescould be moved to here?).Lastly, just went with a simple assembly format. If people would like to see something more fancy, e.g. an initializer-list style format with an elided entry block, let me know: