Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExportVerilog] Fix crash when spilling LTL expr to wire #5625

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

fabianschuiki
Copy link
Contributor

Do not try to resolve use-before-def on LTL expressions by spilling them to a wire. LTL expressions are always emitted inline, so just leave them be in the IR and have ExportVerilog emit them as they are.

Fixes #5613.

Do not try to resolve use-before-def on LTL expressions by spilling them
to a wire. LTL expressions are always emitted inline, so just leave them
be in the IR and have ExportVerilog emit them as they are.

Fixes #5613.
Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fabianschuiki fabianschuiki merged commit b8e41f4 into main Jul 19, 2023
@fabianschuiki fabianschuiki deleted the fschuiki/fix-ltl-prepare-for-emission-crash branch July 19, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ExportVerilog] Prepare for emission crashes on test in regression suit
2 participants