[Calyx]Add invoke pass

[linuxlonelyeagle]

This PR adds the lower invoke operation part to the lower-calyx-to-fsm pass.

[linuxlonelyeagle]

@rachitnigam I've added the pass for lower invoke here.:smile:

[rachitnigam]

Seems reasonable to me for the most part after from the potential name-conflict problem

[cgyurgyik]

Some initial comments.

[mikeurbach]

I left a couple comments about some simple improvements, but I think this is looking pretty good.

[mikeurbach]

This seems good to me.

I think my most recent comment should be taken into account.

[mikeurbach]

Thanks, this looks good to me now.

[linuxlonelyeagle]

@rachitnigam @mortbopet I think you can continue to review the code, and if you have any suggestions, please let me know.:smile:

[linuxlonelyeagle]

@rachitnigam @mortbopet I'll be honest, you're forgetting that there's code to review here.

[cgyurgyik]

Hi, it is common for folks to take weekends off.

Also, I have a few unaddressed comments.

[linuxlonelyeagle]

Sorry, I don't have the sense to take weekends off here. You have questions, feel free to let me know, as I recall I took all your previous suggestions, if there are new ones, feel free to let me know .

[mortbopet]

I am also one of those people who take weekends - please be respectful and mindful of other people's time. Reviewing this part of CIRCT is something we do on our own time, which sometimes leads to multiple days of delay. Make sure that you invest in correctly addressing the feedback you've been granted in prior reviews, and give people time, before pinging them.
Doing so builds good relationships, failing to do so will make it harder to get people to review your stuff in the future.

[linuxlonelyeagle]

I'm really sorry about that, and to be honest with you, I really didn't think about the point about weekend vacations because it doesn't feel like it's taken seriously in the people around me, I hadn't considered this point and it's really something I did wrong. On the other hand, I have my own problems, to be honest and honest, as a fan of llvm, I was desperate to be involved in the llvm project. I will pay more attention in these aspects in the future. Sorry again.

• Make sure that you invest in correctly addressing the feedback you've been granted in prior reviews, and give people time, before pinging them.
  This is clear to me, I know what I did before may not be right, but for you to put forward the suggestion I am very serious consideration(It's also possible that my English is not that good and I don't understand you correctly), I honestly, as a student, I know I have a lot of places to do not good enough, I'm sorry, if there is a do not do a good job (no matter whether it's to write the code or other aspects), in fact, you guys say that I've been very try to do it.

[rachitnigam]

Hey @cgyurgyik, just checking to see if the new changes look good and if we should proceed with a merge of this

[cgyurgyik]

Hi! A few smaller comments to address before submission. Apologies @linuxlonelyeagle, these comments have been pending for a while; I thought they were submitted.

Thank you for your work!

[rachitnigam]

Okay, looks like @linuxlonelyeagle has addressed all the comments. Thank you so much for your work @linuxlonelyeagle! The first PR in a new open source project always ends up taking some time to merge because there are a lot of style-related things to learn but we hope the process was useful for you! Looking forward to your future contributions!

[linuxlonelyeagle]

Thank you all for your guidance.I learned a lot and took the opportunity to contribute to LLVM and CIRCT. The part about calyx.invoke should still have ref functionality to be done, if I have time I'll make it.

[cgyurgyik]

Great! Looking forward to it :). I would also suggest looking at the LLVM Programmer's Manual, since CIRCT falls under LLVM:

https://llvm.org/docs/ProgrammersManual.html