Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyCDE] Add implemented of comparison operators #5654

Merged
merged 3 commits into from
Jul 24, 2023
Merged

[PyCDE] Add implemented of comparison operators #5654

merged 3 commits into from
Jul 24, 2023

Conversation

Dragon-Git
Copy link
Contributor

Fixed: #5653

@Dragon-Git
Update signals.py
f5287bb 
Add comparison operators (<, >, <=, >=)
@Dragon-Git
[pycde] Update signals.py
90efef2 
remove blank line
@teqdruid
Copy link
Contributor

Thanks!

Can you add some tests to

circt/frontends/PyCDE/test/test_hwarith.py

Line 88 in 1f7eafe

?

@teqdruid teqdruid added the PyCDE Python CIRCT Design Entry API label Jul 21, 2023
@Dragon-Git
Copy link
Contributor Author

Thanks!

Can you add some tests to

circt/frontends/PyCDE/test/test_hwarith.py

Line 88 in 1f7eafe

?

I have added a test to the file, please review it.

@Dragon-Git Dragon-Git changed the title [pycde] Add implemented of comparison operators [PyCDE] Add implemented of comparison operators Jul 23, 2023
teqdruid
teqdruid approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teqdruid
Copy link
Contributor

Do you need someone to hit the merge button for you?

@Dragon-Git
Copy link
Contributor Author

Yes, I need help merging my pull request. Thanks.

@teqdruid teqdruid merged commit 919e7d3 into llvm:main Jul 24, 2023
5 checks passed
@teqdruid
Copy link
Contributor

You can request access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access now that you've got some code in circt. Please read all of that document (though not all of it applies to circt.)

teqdruid added a commit that referenced this pull request Jul 24, 2023
@teqdruid
Revert "[PyCDE] Add implemented of comparison operators (#5654)"
bcf69ce 
This reverts commit 919e7d3.

Broke the PyCDE tests with: `TypeError: '<' not supported between
instances of 'BitsSignal' and 'BitsSignal'.`
@Dragon-Git
Copy link
Contributor Author

You can request access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access now that you've got some code in circt. Please read all of that document (though not all of it applies to circt.)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teqdruid teqdruid teqdruid approved these changes

Assignees
No one assigned
Labels
PyCDE Python CIRCT Design Entry API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pycde] Unimplemented of comparison operators
2 participants
@Dragon-Git @teqdruid