Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Move functions from HWMutableModuleLike to HWModuleLike #5656

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

darthscsi
Copy link
Contributor

@darthscsi darthscsi commented Jul 21, 2023

HWMutableModuleLike inherits from HWModuleLike now, so non-mutating functions can move back. Also make MSFTExternalModuleOp HWModuleLike. It was very close before.

Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. That these functions were in HWMutableModuleLike was just a matter of practicality before OpInterfaces supported inheritance. Or possibly before I thought they did.

@darthscsi darthscsi merged commit f854427 into main Jul 21, 2023
@darthscsi darthscsi deleted the dev/darthscsi/hwmodcleanup branch April 11, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants