[Ibis] Call preparation pass -- part 1 #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowering the Ibis control flow starts with converting all calls to the DC dialect's values with one struct representing the packed arguments. In the interest of having small PRs, this only implements narrowing the arguments to one struct. Part 2 will then wrap them in DC values.
mortbopet
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering the Ibis control flow starts with converting all calls to the DC dialect's values with one struct representing the packed arguments.
In the interest of having small PRs, this only implements narrowing the arguments to one struct. Part 2 will then wrap them in DC values.