[HW] Allow default builders for hw.wire. #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the generated Python bindings to generate a useful constructor, which is impossible otherwise.
|
@fabianschuiki I think you added this originally, is there any reason to prevent the default builders? Among other things, if the default builders exist, the generated Python code for this op will have a useful constructor. |
fabianschuiki
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
There might have been some overload resolution ambiguity with StringAttrOrRef, but I think that went away again. LGTM since the tests pass 😃
I wish the builders create by TableGen would accept something like StringAttrOrRef to make it easier to pass in attribute and non-attribute values .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the generated Python bindings to generate a useful constructor, which is impossible otherwise.