[Ibis] Add container and port operations #5747
Conversation
Adds: container, container instantiation, ports and port accesses. Port access rules are implemented as: - "local" port accesses (any port in the current or parent container hierarchy) can be accessed by a flat symbol name - instance port accesses can be accessed by a nested symbol access. - any instance in a parent container can be accessed. - Only the top-level ports of the instance can be accessed (arbitrary restriction).
mortbopet
force-pushed
the
dev/mpetersen/ibis_lo
branch
from
ba969e1
to
900f3b6
Compare
I can get behind having top-level modules continue to be classes, instead of everything a container - it simplifies some of the symbol definition search stuff. Port access functions (as previously discussed) i think have plenty of merit in being general. I think a compromise here is: classes as top level, no nested containers (=> no container instantiation), port-related ops as-is. EDIT: Dipping my toes into the lowering now, and I think I've changed my mind - instance port accesses are semantically different enough from local port accesses to warrant a separate op. |
lib/Dialect/Ibis/IbisOps.cpp
Outdated
| return op->emitOpError() | ||
| << op->getName() << " must be contained in a ClassOp"; | ||
|
|
||
| Operation *rootAccessOp = SymbolTable::lookupSymbolIn(parentClass, symName); |
There was a problem hiding this comment.
This is a linear scan through the parentClass, right? If so, this is unacceptably inefficient longer term. Once we get the innerSym table stuff (on which I am pushing), it'll be more efficient. Please add a TODO comment reflecting this.
Also, doesn't the SymbolTable interface expose a method to do this?
| Operation *rootAccessOp = SymbolTable::lookupSymbolIn(parentClass, symName); | ||
|
|
||
| TTargetOp targetOp; | ||
| if (auto getTargetRes = getTargetOp(rootAccessOp); succeeded(getTargetRes)) |
There was a problem hiding this comment.
I'm surprised you need to do the succeeded check separately.
There was a problem hiding this comment.
FailureOr/LogicalResult is not and has never been implicitly convertible to bool.
test/Dialect/Ibis/round-trip.mlir
Outdated
| ibis.port.input @C_in : i1 | ||
| ibis.port.output @C_out : i1 | ||
|
|
||
| ibis.instance @My_A, @A |
There was a problem hiding this comment.
Let's stick to the camelCase for instance names and CamelCase for class name convention. (I'm a hypocrite here since I never stick to any conventions, but do as I say not as I do! ;) )
lib/Dialect/Ibis/IbisOps.cpp
Outdated
| llvm::function_ref<Type(TSrcOp)> getPortType, | ||
| SymbolTableCollection &symbolTable) { | ||
| auto symName = op.getSymNameAttr(); | ||
| auto localAccess = symName.getNestedReferences().empty(); |
There was a problem hiding this comment.
Beyond referencing ports in nested containers, I think we will need the ability to reference ports in parent/sibling containers. Something like a file system path like: ../../Foo/Bar/data. Will this code be able to be extended to support that?
mortbopet
force-pushed
the
dev/mpetersen/ibis_lo
branch
from
7f5d70b
to
e87fe40
Compare
Adds: container, container instantiation, ports and port accesses.
Port access rules are implemented as: