Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use a consistent key for ccache caching in Short Integration Tests #5770

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Aug 3, 2023

The ccache action by default uses the current date and time as part of the key for caching. The main problem with this is that it can create too many different cache entries, and can eject entries we don't want to be ejected. There isn't a reason to keep more than one copy of this cache around, so using a consistent key will cause it to eject itself. I put the name of the job in the key so that we can identify which entries belong to what jobs when we examine the cache. This change also updates to a newer version of the ccache action.

The default ccache action uses the current time as part of the key for caching.
The main problem with this is that it can cause too many different cache
entries, and can eject entries we want to be ejected.  There isn't a reason to
keep more than one copy of this cache around, so using a consistent key will
cause it to eject itself.  I put the name of the job in the key so that we can
identify which entries belong to what jobs when we examine the cache.  This
change also updates to a newer version of the ccache action.
@youngar
Copy link
Member Author

youngar commented Aug 3, 2023

The new key evaluates to shortintegration-ON-Release-clang

@youngar youngar linked an issue Aug 3, 2023 that may be closed by this pull request
@youngar youngar merged commit f665c37 into main Aug 3, 2023
5 checks passed
@youngar youngar deleted the github-actions-ccache branch August 3, 2023 06:19
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ShortIntegrationTests.yml - don't save cache with date
2 participants