Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] .clang-tidy: Disable misc-use-anonymous-namespace . #5775

Merged
merged 1 commit into from
Aug 3, 2023
Merged

[NFC] .clang-tidy: Disable misc-use-anonymous-namespace . #5775

merged 1 commit into from
Aug 3, 2023

Conversation

dtzSiFive
Copy link
Contributor

Conflicts with coding standard re:static methods,
see upstream's similar change:
4c9f1584ce2c373dc571068af5fd65f2e16d05d2 .

@dtzSiFive
[NFC] .clang-tidy: Disable misc-use-anonymous-namespace .
ba1bbe4 
Conflicts with coding standard re:static methods,
see upstream's similar change:
4c9f1584ce2c373dc571068af5fd65f2e16d05d2 .
teqdruid
teqdruid approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've always said that we should just use upstreams style config.

@dtzSiFive dtzSiFive merged commit cb2aa8b into llvm:main Aug 3, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the feature/clang-tidy-use-anonymous-namespace branch August 3, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teqdruid teqdruid teqdruid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @teqdruid