[Ibis] Add ibis.this
#5794
Merged
[Ibis] Add ibis.this
#5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds an `ibis.this` operation to define the current scope. - Renames `!ibis.classref` to `!ibis.scoperef` since this type must now be able to support both classes and containers - Adds a `ScopeOpInterface` - `ibis.get_parent_of_ref` now can take an explicit type to cast the parent ref to.
blakep-msft
reviewed
Aug 7, 2023
| parser.parseArgument(thisArg, /*allowType=*/false) || | ||
| parser.parseRParen()) | ||
| return failure(); | ||
| if (std::next(thisOps.begin()) != thisOps.end()) |
There was a problem hiding this comment.
Why not use thisOps.size() rather than comparing iterators?
There was a problem hiding this comment.
getOps returns an iterator_range which has begin, end, empty. So one can either use std::distance or the above... went with the above, although std::distance is probably the better, more readable, option to infer the size.
teqdruid
approved these changes
Aug 7, 2023
| auto parentScope = | ||
| dyn_cast_or_null<ScopeOpInterface>(getOperation()->getParentOp()); | ||
| if (!parentScope) | ||
| return emitOpError() << "thisOp must be nested in a scope op"; |
There was a problem hiding this comment.
Can you express this in ODS with HasParent<ScopeOpInterface>?
There was a problem hiding this comment.
Nope, generated code expects a static getOperationName to be defined for the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibis.thisoperation to define the current scope.!ibis.classrefto!ibis.scoperefsince this type must now be able to support both classes and containersScopeOpInterfaceibis.get_parent_of_refnow takes an explicit type to cast the parent ref to. In mostclasscases, this will be an opaque type, but forcontainers these will reference the explicit parent type. The obvious benefit of this is that you're able to performget_porton resolvedscopereftypes.