[Ibis] Add containerize pass #5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pass converts Ibis classes to containers, and outlines containers inside classes.
teqdruid
reviewed
Aug 8, 2023
| .getDefiningOp()); | ||
| rewriter.setInsertionPoint(thisOp); | ||
| rewriter.replaceOpWithNewOp<ThisOp>(thisOp, newContainer.getNameAttr()); | ||
| return success(); |
There was a problem hiding this comment.
Shouldn't this leave behind something in the class to indicate that "this container which got moved needs to be instantiated here". Or something in the container op to indicate which class is the parent it got moved out of?
There was a problem hiding this comment.
Woops, correct. Added ContainerInstanceOp, lowering from the class InstanceOp to said op + addition of an instance op during container outlining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass converts Ibis classes to containers, and outlines containers inside classes.