-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ibis] Add containerize pass #5810
Conversation
This pass converts Ibis classes to containers, and outlines containers inside classes.
.getDefiningOp()); | ||
rewriter.setInsertionPoint(thisOp); | ||
rewriter.replaceOpWithNewOp<ThisOp>(thisOp, newContainer.getNameAttr()); | ||
return success(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this leave behind something in the class to indicate that "this container which got moved needs to be instantiated here". Or something in the container op to indicate which class is the parent it got moved out of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, correct. Added ContainerInstanceOp
, lowering from the class InstanceOp
to said op + addition of an instance op during container outlining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nits.
This pass converts Ibis classes to containers, and outlines containers inside classes.