[PipelineToHW] Fix PipelineToHW TSAN issue
#5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a TSAN issue due to concurrent additions (and removals) to the top-level mlir::ModuleOp symbol table, whilst the pass is running at a hw::HWModuleOp granularity.
mortbopet
changed the title
PipelineToHW TSAN issue #5815PipelineToHW TSAN issue
dtzSiFive
reviewed
Aug 9, 2023
| // here by allowing this pass to run on a per-hwmodule/whatever container the | ||
| // pipeline is nested within-granularity. However, this conversion adds (and removes) | ||
| // new modules to the top-level mlir::ModuleOp scope, which technically violates | ||
| // hw::HWModuleLike's IsolatedFromAbove (and thus has previously caused |
There was a problem hiding this comment.
FWIW don't think whether it's IsolatedFromAbove is relevant, it's that passes cannot change the containing operation (or even the current one in ways that's visible/possibly-breaking to other operations, such as adding/removing ports of a hw.module from a pass running on hw.module's).
There was a problem hiding this comment.
passes cannot change the containing operation
I see IsolatedFromAbove as a trait inherently linked to the passmanager, and how passes are scheduled. IsolatedFromAbove allows multi-threaded execution, which in turn is what "allows" these errors to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a TSAN issue due to concurrent additions (and removals) to the top-level mlir::ModuleOp symbol table, whilst the pass is running at a hw::HWModuleOp granularity.
fixes #5815