[Python] Use Ninja and LLD when building wheel if available #6165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
approved these changes
Sep 21, 2023
…/test-faster-wheel
|
Thanks! Checked here https://github.com/llvm/circt/actions/runs/6325163538. |
mikeurbach
pushed a commit
that referenced
this pull request
Oct 2, 2023
Ninja + LLD builds much faster than the default config (make+ld) so use it when they are in PATH. CI would not be affected by this as manylinux seems not to have ninja and lld by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ninja + LLD builds much faster than the default config (make+ld) so use it when they are in PATH. CI would not be affected by this as manylinux seems not to have ninja and lld by default.