[Ibis] Add ibis.sblock.isolated #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post-argification it makes a lot of sense to have an IsolatedFromAbove block: 1. for pass scheduling purposes (eg. prepare-scheduling pass) 2. To ensure that constants aren't being pulled out of `ibis.sblock`s during canonicalization (which makes things harder post-handshake conversion, when we expect argification to persist)
mortbopet
force-pushed
the
dev/mpetersen/ibis_isolated_sblock
branch
from
c4b2b6a
to
38c550a
Compare
mikeurbach
pushed a commit
that referenced
this pull request
Oct 2, 2023
Post-argification it makes a lot of sense to have an IsolatedFromAbove block: 1. for pass scheduling purposes (eg. prepare-scheduling pass) 2. To ensure that constants aren't being pulled out of `ibis.sblock`s during canonicalization (which makes things harder post-handshake conversion, when we expect argification to persist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-argification it makes a lot of sense to have an IsolatedFromAbove block:
ibis.sblocks during canonicalization (which makes things harder post-handshake conversion, when we expect argification to persist)