[Seq] Remove custom printer/parser for seq.compreg(.ce) ops
#6267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed in favor of using a generated parser + a couple of custom directives to resolve the optional name and types of the implicit operands.
fabianschuiki
approved these changes
Oct 9, 2023
Comment on lines
+50
to
+51
| custom<OptionalTypeMatch>(ref(type($data)), ref($resetValue), type($resetValue)) | ||
| custom<OptionalTypeMatch>(ref(type($data)), ref($powerOnValue), type($powerOnValue)) |
There was a problem hiding this comment.
That is pretty clever! I hadn't considered using a custom parser to get some of the optional typing going.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in favor of using a generated parser + a couple of custom directives to resolve the optional name and types of the implicit operands.