[ESI][Runtime] When a service cannot be created, ignore it #6462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If createService returns null, it means either that service hasn't been connected up externally or we do not have an implementation for it. Either way, just ignore it and let it error when/if the user tries to access it. Also, pass the implementation name to createService to make it easier to check compat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If createService returns null, it means either that service hasn't been
connected up externally or we do not have an implementation for it.
Either way, just ignore it and let it error when/if the user tries to
access it.
Also, pass the implementation name to createService to make it easier to
check compat.