[Arc] Add support for struct and array states #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
approved these changes
Dec 10, 2023
| @@ -16,16 +16,17 @@ class ArcTypeDef<string name> : TypeDef<ArcDialect, name> { } | |||
|
|
|||
| def StateType : ArcTypeDef<"State"> { | |||
| let mnemonic = "state"; | |||
| let parameters = (ins "::mlir::IntegerType":$type); | |||
| let parameters = (ins "::mlir::Type":$type); | |||
There was a problem hiding this comment.
Can we add a verifier to check that the getBitWidth helper can compute a valid result for the nested type?
That way we have it as an invariant and don't have to check for a valid return value each time we call getBitWidth. Plus a regression test triggering it.
There was a problem hiding this comment.
Yeah great point
Allow `!arc.state` to carry HW structs and arrays. The state only has to be able to compute the bit width of the inner type, but it does not care what exactly this type is. Rework the Arc-to-LLVM lowering to do the entire lowering in one full conversion, instead of two separate ones. There is no real need for the split, and combining all patterns into one large conversion allows all Arc types to be directly converted to LLVM types. Previously, after the first partial conversion the IR would be in a strange in-between state of mixing Arc types into LLVM operations (for example, loads and stores of HW struct/array types).
fabianschuiki
force-pushed
the
fschuiki/arc-struct-array-states
branch
from
0c6727a
to
6560d98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
!arc.stateto carry HW structs and arrays. The state only has to be able to compute the bit width of the inner type, but it does not care what exactly this type is.Rework the Arc-to-LLVM lowering to do the entire lowering in one full conversion, instead of two separate ones. There is no real need for the split, and combining all patterns into one large conversion allows all Arc types to be directly converted to LLVM types. Previously, after the first partial conversion the IR would be in a strange in-between state of mixing Arc types into LLVM operations (for example, loads and stores of HW struct/array types).