[SMT] Add SMT-LIB export translation #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
I'm no expert on the SMT-LIB format, but from what I've seen of it, this looks good. I like the use of a visitor to produce the output, and the proper organization into a Target. And ExportSMTLIB itself is nicely factored into emission per supported theory. Very neat.
LGTM 🥳
math-fehr
approved these changes
Mar 27, 2024
maerhart
force-pushed
the
maerhart-smtlibexporter
branch
from
136edac
to
00c2702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quantifier patterns and other attributes are not yet supported, but will be added in a future PR since this one is already quite big. Feel free to let me know if I should split it up