[Docs] GettingStarted: Fix images and LLVM/MLIR contributing guide #6873
Conversation
ubfx
changed the title
There was a problem hiding this comment.
😞 the issue with the links and images is known. It has been brought up before, for example here: #4343 (comment)
Basically, if we make the change in this PR, they'll work when viewed on GitHub, but will be broken on the actual website circt.llvm.org. No one has taken the time to figure out an approach that works in both scenarios.
The part about the LLVM/MLIR contribution process is great though, thanks for updating that. If you back out the changes to the links, we can merge that part.
If you're interested in figuring out how to specify the links in a way that works on both GitHub and the website, that would be great too, but the current change would break the website, which we want to keep working.
ubfx
force-pushed
the
getting-started-doc-fixes
branch
from
36c537a
to
82e55fb
Compare
|
Ah, thanks for the explanation. I was wondering if I was missing something. I removed the image related changes from this PR but will take a look if I can figure out how to make this work with the website |
|
Awesome, that sounds good to me. |
No description provided.