Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Remove support for printf-encoded verification, tests. #7010

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/Dialect/FIRRTL/Import/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ add_circt_translation_library(CIRCTImportFIRFile
FIRAnnotations.cpp
FIRLexer.cpp
FIRParser.cpp
FIRParserAsserts.cpp

ADDITIONAL_HEADER_DIRS

Expand Down
4 changes: 0 additions & 4 deletions lib/Dialect/FIRRTL/Import/FIRAnnotations.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ bool fromOMIRJSON(llvm::json::Value &value,
SmallVectorImpl<Attribute> &annotations,
llvm::json::Path path, MLIRContext *context);

/// Classifier for legacy verif intent captured in printf + when's. Returns
/// true if the printf encodes verif intent, false otherwise.
bool isRecognizedPrintfEncodedVerif(PrintFOp printOp);

} // namespace firrtl
} // namespace circt

Expand Down
27 changes: 0 additions & 27 deletions lib/Dialect/FIRRTL/Import/FIRParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5390,33 +5390,6 @@ FIRCircuitParser::parseModuleBody(const SymbolTable &circuitSymTbl,
if (failed(result))
return result;

// Scan for printf-encoded verif's to error on their use, no longer supported.
{
size_t numVerifPrintfs = 0;
std::optional<Location> printfLoc;

deferredModule.moduleOp.walk([&](PrintFOp printFOp) {
if (!circt::firrtl::isRecognizedPrintfEncodedVerif(printFOp))
return;
++numVerifPrintfs;
if (!printfLoc)
printfLoc = printFOp.getLoc();
});

if (numVerifPrintfs > 0) {
auto diag =
mlir::emitError(deferredModule.moduleOp.getLoc(), "module contains ")
<< numVerifPrintfs
<< " printf-encoded verification operation(s), which are no longer "
"supported.";
diag.attachNote(*printfLoc)
<< "example printf here, this is now just a printf and nothing more";
diag.attachNote() << "For more information, see "
"https://github.com/llvm/circt/issues/6970";
return diag;
}
}

// Demote any forceable operations that aren't being forced.
deferredModule.moduleOp.walk([](Forceable fop) {
if (fop.isForceable() && fop.getDataRef().use_empty())
Expand Down
81 changes: 0 additions & 81 deletions lib/Dialect/FIRRTL/Import/FIRParserAsserts.cpp

This file was deleted.

78 changes: 0 additions & 78 deletions test/Dialect/FIRRTL/SFCTests/complex-asserts.fir

This file was deleted.

63 changes: 0 additions & 63 deletions test/Dialect/FIRRTL/SFCTests/complex-assumes.fir

This file was deleted.

115 changes: 0 additions & 115 deletions test/Dialect/FIRRTL/when-encoded-verif.fir

This file was deleted.

Loading