Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLHD] Fix operand assignments not going through rewriter. #7055

Merged
merged 1 commit into from
May 16, 2024
Merged

[LLHD] Fix operand assignments not going through rewriter. #7055

merged 1 commit into from
May 16, 2024

Conversation

dtzSiFive
Copy link
Contributor

Detected by -DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=ON.

cc #7047.

@dtzSiFive
[LLHD] Fix operand assignments not going through rewriter.
8091658 
Detected by -DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=ON.

cc llvm#7047.
@dtzSiFive dtzSiFive added the LLHD label May 16, 2024
fabianschuiki
fabianschuiki approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this!

I'm wondering whether we should have a run with these checks enabled in CI somewhere 🤔

@dtzSiFive
Copy link
Contributor Author

I'm wondering whether we should have a run with these checks enabled in CI somewhere 🤔

I think so! Very much so. Cronjob on some machine if nothing else 😄 .

I'd say also regularly checking ASAN+UBSAN is a good idea 👍.
And filecheck_lint.py .

Especially once we're clean w.r.t. these checks.

@dtzSiFive dtzSiFive merged commit cb397bb into llvm:main May 16, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the fix/llhd-array-rewriter branch May 16, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@maerhart maerhart Awaiting requested review from maerhart maerhart is a code owner

Assignees
No one assigned
Labels
LLHD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @fabianschuiki