[ImportVerilog][Moore] Support union type

[mingzheTerapines]

Translate union type only from slang to moore.
Add moore.union_create and morre.union_extract OPs.
More tests and Mem2Reg pass will be imporved.

[mingzheTerapines]

@fabianschuiki @hailongSun2000 just like the name of class StructLikeType, I strongly recommand renaming struct StructMember in MooreTypes.h with struct StructLikeMember which is more proper for both struct and union types.

[hailongSun2000]

@fabianschuiki @hailongSun2000 just like the name of class StructLikeType, I strongly recommand renaming struct StructMember in MooreTypes.h with struct StructLikeMember which is more proper for both struct and union types.

Yeah, exactly!

[mingzheTerapines]

2024-05-28T06:28:32.5031885Z ##[group]Run # Display patches
2024-05-28T06:28:32.5032312Z �[36;1m# Display patches�[0m
2024-05-28T06:28:32.5032851Z �[36;1mif [ ! -z clang-format.patch ]; then�[0m
2024-05-28T06:28:32.5033333Z �[36;1m  echo "Clang-format patch"�[0m
2024-05-28T06:28:32.5033712Z �[36;1m  echo "================"�[0m
2024-05-28T06:28:32.5034208Z �[36;1m  cat clang-format.patch�[0m
2024-05-28T06:28:32.5034607Z �[36;1m  echo "================"�[0m
2024-05-28T06:28:32.5034956Z �[36;1mfi�[0m
2024-05-28T06:28:32.5035381Z shell: sh -e {0}
2024-05-28T06:28:32.5035692Z env:
2024-05-28T06:28:32.5035968Z   DIFF_COMMIT_NAME: main
2024-05-28T06:28:32.5036459Z   DIFF_COMMIT: 695e36e5d480780f830bf2ded05c3fb8c8eb6012
2024-05-28T06:28:32.5036936Z ##[endgroup]
2024-05-28T06:28:32.5808626Z Clang-format patch
2024-05-28T06:28:32.5810671Z ================
2024-05-28T06:28:32.5817660Z diff --git a/lib/Conversion/ImportVerilog/Types.cpp b/lib/Conversion/ImportVerilog/Types.cpp
2024-05-28T06:28:32.5819813Z index 74cfb23..0f99c53 100644
2024-05-28T06:28:32.5822658Z --- a/lib/Conversion/ImportVerilog/Types.cpp
2024-05-28T06:28:32.5823760Z +++ b/lib/Conversion/ImportVerilog/Types.cpp
2024-05-28T06:28:32.5834578Z @@ -101,8 +101,9 @@ struct TypeVisitor {
2024-05-28T06:28:32.5835517Z    }
2024-05-28T06:28:32.5860080Z  
2024-05-28T06:28:32.5860839Z    // Collect the members in a struct or union.
2024-05-28T06:28:32.5875045Z -  LogicalResult collectMembers(const slang::ast::Scope &structType,
2024-05-28T06:28:32.5876574Z -                               SmallVectorImpl<moore::StructLikeMember> &members) {
2024-05-28T06:28:32.5877505Z +  LogicalResult
2024-05-28T06:28:32.5878308Z +  collectMembers(const slang::ast::Scope &structType,
2024-05-28T06:28:32.5879415Z +                 SmallVectorImpl<moore::StructLikeMember> &members) {
2024-05-28T06:28:32.5880645Z      for (auto &field : structType.membersOfType<slang::ast::FieldSymbol>()) {
2024-05-28T06:28:32.5882092Z        auto name = StringAttr::get(context.getContext(), field.name);
2024-05-28T06:28:32.5883217Z        auto innerType = context.convertType(*field.getDeclaredType());
2024-05-28T06:28:32.5884132Z ================

Refer to 10_clang format patches display.txt, clang let me add a return symbol.

[fabianschuiki]

Can you add a few checks with UnionType here and ensure that .getBitSize() returns the correct numbers for unions? I think in contrast to structs you would want to return the size of the largest member in the union. That's worth quickly checking here 😃

[mingzheTerapines]

Sorry for missing this part, code has been uploaded.
BTW, I found some keyword-tagged unsupported cases and submitted an issue with slang developer. These cases will need we do some type checking in pass importVerilog.
MikePopoloski/slang#1012

[fabianschuiki]

Thanks for adding all the tests, and reporting issues upstream with Slang! This looks great 🥳