Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][ABI][NFC] Prime AArch64 CC lowering #679

Merged
merged 5 commits into from
Jun 22, 2024

Conversation

sitio-couto
Copy link
Collaborator

This patch is a preparation for the AArch64 calling convention lowering. It adds the basic infrastructure to initialize the AArch64 ABI details and validates it against a trivial void return and argument call conv lowering.

@sitio-couto sitio-couto self-assigned this Jun 11, 2024
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, one minor change!

@sitio-couto
Copy link
Collaborator Author

@bcardosolopes applied.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, see my comment about "using namespace"

@sitio-couto sitio-couto force-pushed the vinicius/prime-aarch64-cc-lowering branch from 4f2949f to 8af1e57 Compare June 15, 2024 10:12
@sitio-couto
Copy link
Collaborator Author

@bcardosolopes applied.

@bcardosolopes
Copy link
Member

I'm going to approve this, but this should wait until #691 is fixed.

@bcardosolopes
Copy link
Member

I landed the other fixes for the linker issues, thank you so much for fixing those. Feel free to land this whenever you feel it's ready too.

This patch is a preparation for the AArch64 calling convention lowering.
It adds the basic infrastructure to initialize the AArch64 ABI details
and validates it against a trivial void return and argument call conv
lowering.
@sitio-couto sitio-couto force-pushed the vinicius/prime-aarch64-cc-lowering branch from 8af1e57 to 8c475be Compare June 22, 2024 12:44
@sitio-couto sitio-couto merged commit c289083 into llvm:main Jun 22, 2024
6 checks passed
@sitio-couto sitio-couto deleted the vinicius/prime-aarch64-cc-lowering branch June 22, 2024 14:19
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This patch is a preparation for the AArch64 calling convention lowering.
It adds the basic infrastructure to initialize the AArch64 ABI details
and validates it against a trivial void return and argument call conv
lowering.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This patch is a preparation for the AArch64 calling convention lowering.
It adds the basic infrastructure to initialize the AArch64 ABI details
and validates it against a trivial void return and argument call conv
lowering.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This patch is a preparation for the AArch64 calling convention lowering.
It adds the basic infrastructure to initialize the AArch64 ABI details
and validates it against a trivial void return and argument call conv
lowering.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This patch is a preparation for the AArch64 calling convention lowering.
It adds the basic infrastructure to initialize the AArch64 ABI details
and validates it against a trivial void return and argument call conv
lowering.
lanza pushed a commit that referenced this pull request Nov 5, 2024
This patch is a preparation for the AArch64 calling convention lowering.
It adds the basic infrastructure to initialize the AArch64 ABI details
and validates it against a trivial void return and argument call conv
lowering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants