Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR] Fix TargetLowering library depencies #687

Closed
wants to merge 3 commits into from
Closed

[CIR] Fix TargetLowering library depencies #687

wants to merge 3 commits into from

Conversation

sitio-couto
Copy link
Collaborator

This patch fixes the library dependencies of the CIRTargetLowering library. It would fail to build with `BUILD_SHARED_LIBS=ON``.

@sitio-couto
[CIR] Fix TargetLowering library depencies
b33e1d3 
This patch fixes the library dependencies of the CIRTargetLowering
library. It would fail to build with `BUILD_SHARED_LIBS=ON``.
@sitio-couto sitio-couto self-assigned this Jun 14, 2024
@sitio-couto sitio-couto mentioned this pull request Jun 14, 2024
Open
gitoleg
gitoleg approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@gitoleg gitoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me! thanks!!!

bcardosolopes
bcardosolopes reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Some discussion below!

clang/include/clang/CIR/Dialect/IR/CIRDataLayout.h Outdated Show resolved Hide resolved
@sitio-couto
Copy link
Collaborator Author

@bcardosolopes applied.

@sitio-couto sitio-couto force-pushed the vinicius/fix-shared-libs-build branch from db4a7a0 to b87ddfb Compare June 15, 2024 10:22
bcardosolopes
bcardosolopes approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might help with #691, I'm going to approve it already, but feel free to land this as part of whatever solution you find out for #691

sitio-couto added a commit to sitio-couto/clangir that referenced this pull request Jun 18, 2024
@sitio-couto
[CIR] Fix TargetLowering library depencies (llvm#687)
18f8b5c 
This patch fixes the library dependencies of the CIRTargetLowering
library. It would fail to build with `BUILD_SHARED_LIBS=ON``.
sitio-couto added a commit to sitio-couto/clangir that referenced this pull request Jun 18, 2024
@sitio-couto
[CIR] Fix TargetLowering library depencies (llvm#687)
0a5ac57 
This patch fixes the library dependencies of the CIRTargetLowering
library. It would fail to build with `BUILD_SHARED_LIBS=ON``.
@sitio-couto sitio-couto mentioned this pull request Jun 18, 2024
Merged
bcardosolopes pushed a commit that referenced this pull request Jun 20, 2024
@sitio-couto
[CIR][ABI] Replay TargetLowering library reverted commits (#697)
96d46c2 
Essentially re-applies #668 and #678, but also includes #687 which
patched build introduced by the other two PRs.

Closes #691
@bcardosolopes
Copy link
Member

Seems like this got superseded by 697, closing!

@sitio-couto sitio-couto deleted the vinicius/fix-shared-libs-build branch September 10, 2024 22:45
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][ABI] Replay TargetLowering library reverted commits (llvm#697)
361107d 
Essentially re-applies llvm#668 and llvm#678, but also includes llvm#687 which
patched build introduced by the other two PRs.

Closes llvm#691
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][ABI] Replay TargetLowering library reverted commits (llvm#697)
7f17f17 
Essentially re-applies llvm#668 and llvm#678, but also includes llvm#687 which
patched build introduced by the other two PRs.

Closes llvm#691
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
@sitio-couto @smeenai
[CIR][ABI] Replay TargetLowering library reverted commits (llvm#697)
f5a7c3d 
Essentially re-applies llvm#668 and llvm#678, but also includes llvm#687 which
patched build introduced by the other two PRs.

Closes llvm#691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@gitoleg gitoleg gitoleg approved these changes

Assignees

@sitio-couto sitio-couto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sitio-couto @bcardosolopes @gitoleg