[InstCombine] Drop poison flags in simplifyAssocCastAssoc()

The nneg flag on zext may no longer hold after the reassociation.
llvm · Nov 9, 2023 · 1b1c817 · 1b1c817
1 parent 0bd0d72
commit 1b1c817
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -356,6 +356,7 @@ static bool simplifyAssocCastAssoc(BinaryOperator *BinOp1,
 
   IC.replaceOperand(*Cast, 0, BinOp2->getOperand(0));
   IC.replaceOperand(*BinOp1, 1, FoldedC);
+  Cast->dropPoisonGeneratingFlags();
   return true;
 }
 

diff --git a/llvm/test/Transforms/InstCombine/assoc-cast-assoc.ll b/llvm/test/Transforms/InstCombine/assoc-cast-assoc.ll
@@ -77,8 +77,9 @@ define <2 x i32> @AndZextAndVec(<2 x i8> %a) {
 
 define i24 @zext_nneg(i16 %a) {
 ; CHECK-LABEL: @zext_nneg(
-; CHECK-NEXT:    [[RESIZE:%.*]] = zext nneg i16 [[A:%.*]] to i24
-; CHECK-NEXT:    ret i24 [[RESIZE]]
+; CHECK-NEXT:    [[TMP1:%.*]] = and i16 [[A:%.*]], 32767
+; CHECK-NEXT:    [[AND2:%.*]] = zext nneg i16 [[TMP1]] to i24
+; CHECK-NEXT:    ret i24 [[AND2]]
 ;
   %and1 = and i16 %a, 32767
   %resize = zext nneg i16 %and1 to i24