-
Notifications
You must be signed in to change notification settings - Fork 12k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland: "[ADT] fix filter_iterator_impl::operator++"
- Loading branch information
Showing
1 changed file
with
10 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c36226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this broke our AMDGPU builds, see https://lab.llvm.org/staging/#/builders/247/builds/2711 and https://lab.llvm.org/buildbot/#/builders/193.
1c36226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fixed by 1882a4e. Sorry about that
1c36226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still broken after those, see the bots
1c36226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example? All the emails I am seeing are from before that fix
1c36226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that reverting both those patches unblocks my build. This is when compiling for the GPU runtime, so presumably if you add
-DLLVM_ENABLE_RUNTIMES=openmp
it'll try to build it for the GPU.1c36226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one, as well. Sorry about that. Let me revert