Skip to content

Commit 572fc89

Browse files
committed
[lldb][NFC] Move all completer subclasses into source file
They are all implementation details so let's keep them out of the interface. Also makes this code more readable by keeping these small classes not spread over header and source file.
1 parent 7e5d8a3 commit 572fc89

File tree

2 files changed

+202
-248
lines changed

2 files changed

+202
-248
lines changed

lldb/include/lldb/Interpreter/CommandCompletions.h

Lines changed: 0 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -94,94 +94,6 @@ class CommandCompletions {
9494
static void VariablePath(CommandInterpreter &interpreter,
9595
CompletionRequest &request, SearchFilter *searcher);
9696

97-
// The Completer class is a convenient base class for building searchers that
98-
// go along with the SearchFilter passed to the standard Completer functions.
99-
class Completer : public Searcher {
100-
public:
101-
Completer(CommandInterpreter &interpreter, CompletionRequest &request);
102-
103-
~Completer() override;
104-
105-
CallbackReturn SearchCallback(SearchFilter &filter, SymbolContext &context,
106-
Address *addr) override = 0;
107-
108-
lldb::SearchDepth GetDepth() override = 0;
109-
110-
virtual void DoCompletion(SearchFilter *filter) = 0;
111-
112-
protected:
113-
CommandInterpreter &m_interpreter;
114-
CompletionRequest &m_request;
115-
116-
private:
117-
DISALLOW_COPY_AND_ASSIGN(Completer);
118-
};
119-
120-
// SourceFileCompleter implements the source file completer
121-
class SourceFileCompleter : public Completer {
122-
public:
123-
SourceFileCompleter(CommandInterpreter &interpreter,
124-
CompletionRequest &request);
125-
126-
lldb::SearchDepth GetDepth() override;
127-
128-
Searcher::CallbackReturn SearchCallback(SearchFilter &filter,
129-
SymbolContext &context,
130-
Address *addr) override;
131-
132-
void DoCompletion(SearchFilter *filter) override;
133-
134-
private:
135-
FileSpecList m_matching_files;
136-
const char *m_file_name;
137-
const char *m_dir_name;
138-
139-
DISALLOW_COPY_AND_ASSIGN(SourceFileCompleter);
140-
};
141-
142-
// ModuleCompleter implements the module completer
143-
class ModuleCompleter : public Completer {
144-
public:
145-
ModuleCompleter(CommandInterpreter &interpreter,
146-
CompletionRequest &request);
147-
148-
lldb::SearchDepth GetDepth() override;
149-
150-
Searcher::CallbackReturn SearchCallback(SearchFilter &filter,
151-
SymbolContext &context,
152-
Address *addr) override;
153-
154-
void DoCompletion(SearchFilter *filter) override;
155-
156-
private:
157-
const char *m_file_name;
158-
const char *m_dir_name;
159-
160-
DISALLOW_COPY_AND_ASSIGN(ModuleCompleter);
161-
};
162-
163-
// SymbolCompleter implements the symbol completer
164-
class SymbolCompleter : public Completer {
165-
public:
166-
SymbolCompleter(CommandInterpreter &interpreter,
167-
CompletionRequest &request);
168-
169-
lldb::SearchDepth GetDepth() override;
170-
171-
Searcher::CallbackReturn SearchCallback(SearchFilter &filter,
172-
SymbolContext &context,
173-
Address *addr) override;
174-
175-
void DoCompletion(SearchFilter *filter) override;
176-
177-
private:
178-
RegularExpression m_regex;
179-
typedef std::set<ConstString> collection;
180-
collection m_match_set;
181-
182-
DISALLOW_COPY_AND_ASSIGN(SymbolCompleter);
183-
};
184-
18597
private:
18698
static CommonCompletionElement g_common_completions[];
18799
};

0 commit comments

Comments
 (0)