Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ThinLTO] Support opt remarks options with distributed ThinLTO backends
Summary: Passes down the necessary code ge options to the LTO Config to enable -fdiagnostics-show-hotness and -fsave-optimization-record in the ThinLTO backend for a distributed build. Also, remove warning about not having PGO when the input is IR. Reviewers: pcc Subscribers: mehdi_amini, inglorion, eraman, cfe-commits Differential Revision: https://reviews.llvm.org/D46464 llvm-svn: 331592
- Loading branch information
1 parent
81d9207
commit 66744f8
Showing
4 changed files
with
56 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
clang/test/CodeGen/thinlto-diagnostic-handler-remarks-with-hotness.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
; Test to ensure -fdiagnostics-show-hotness and -fsave-optimization-record | ||
; work when invoking the ThinLTO backend path. | ||
; RUN: opt -module-summary -o %t.o %s | ||
; RUN: llvm-lto -thinlto -o %t %t.o | ||
|
||
; First try with pass remarks to stderr | ||
; RUN: %clang -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -mllvm -pass-remarks=inline -fdiagnostics-show-hotness -o %t2.o -c 2>&1 | FileCheck %s | ||
|
||
; CHECK: tinkywinky inlined into main with cost=0 (threshold=337) (hotness: 300) | ||
|
||
; Next try YAML pass remarks file | ||
; RUN: rm -f %t2.opt.yaml | ||
; RUN: %clang -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -fsave-optimization-record -fdiagnostics-show-hotness -o %t2.o -c | ||
; RUN: cat %t2.opt.yaml | FileCheck %s -check-prefix=YAML | ||
|
||
; YAML: --- !Passed | ||
; YAML-NEXT: Pass: inline | ||
; YAML-NEXT: Name: Inlined | ||
; YAML-NEXT: Function: main | ||
; YAML-NEXT: Hotness: 300 | ||
; YAML-NEXT: Args: | ||
; YAML-NEXT: - Callee: tinkywinky | ||
; YAML-NEXT: - String: ' inlined into ' | ||
; YAML-NEXT: - Caller: main | ||
; YAML-NEXT: - String: ' with cost=' | ||
; YAML-NEXT: - Cost: '0' | ||
; YAML-NEXT: - String: ' (threshold=' | ||
; YAML-NEXT: - Threshold: '337' | ||
; YAML-NEXT: - String: ')' | ||
; YAML-NEXT: ... | ||
|
||
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" | ||
target triple = "x86_64-scei-ps4" | ||
|
||
declare i32 @patatino() | ||
|
||
define i32 @tinkywinky() { | ||
%a = call i32 @patatino() | ||
ret i32 %a | ||
} | ||
|
||
define i32 @main() !prof !0 { | ||
%i = call i32 @tinkywinky() | ||
ret i32 %i | ||
} | ||
|
||
!0 = !{!"function_entry_count", i64 300} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters