Skip to content

Commit a20fc93

Browse files
authored
[Dexter] llvm-lit: always log DAP messages (#157145)
Buildbot cross-project-tests-sie-ubuntu sees sporadic test failures due to missing "stackTrace" "source" "path". The "path" field is optional for "source" according to DAP, so it's well formed. It works most of the time, and doesn't consistently fail for any one test which is all strangely inconsistent. The failures couldn't be reproduced locally after running the feature_tests in a loop for 3 hours. I haven't been able to work out why the "source" is sometimes missing by just looking at LLDB code. With this patch, we might be able to get clues about the flaky tests with well timed log inspection.
1 parent fe6e178 commit a20fc93

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

cross-project-tests/lit.cfg.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def configure_dexter_substitutions():
121121
tools.append(
122122
ToolSubst(
123123
"%dexter_lldb_args",
124-
f'--lldb-executable "{lldb_dap_path}" --debugger lldb-dap',
124+
f'--lldb-executable "{lldb_dap_path}" --debugger lldb-dap --dap-message-log=%t.dap.log',
125125
)
126126
)
127127

@@ -148,7 +148,9 @@ def configure_dexter_substitutions():
148148
dexter_regression_test_c_builder = "clang"
149149
dexter_regression_test_cxx_builder = "clang++"
150150
dexter_regression_test_debugger = "lldb-dap"
151-
dexter_regression_test_additional_flags = f'--lldb-executable "{lldb_dap_path}"'
151+
dexter_regression_test_additional_flags = (
152+
f'--lldb-executable "{lldb_dap_path}" --dap-message-log=%t.dap.log'
153+
)
152154
dexter_regression_test_c_flags = "-O0 -glldb -std=gnu11"
153155
dexter_regression_test_cxx_flags = "-O0 -glldb -std=gnu++11"
154156

0 commit comments

Comments
 (0)