Skip to content

Commit

Permalink
[libc] reset errno in isatty tests
Browse files Browse the repository at this point in the history
Errno wasn't getting reset between tests, causing cascading failures.

Differential Revision: https://reviews.llvm.org/D135627
  • Loading branch information
michaelrj-google committed Oct 10, 2022
1 parent d325d2b commit aec239c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions libc/test/src/unistd/isatty_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ using __llvm_libc::testing::ErrnoSetterMatcher::Succeeds;
TEST(LlvmLibcIsATTYTest, StdInOutTests) {
// If stdin is connected to a terminal, assume that all of the standard i/o
// fds are.
errno = 0;
if (__llvm_libc::isatty(0)) {
EXPECT_THAT(__llvm_libc::isatty(0), Succeeds(1)); // stdin
EXPECT_THAT(__llvm_libc::isatty(1), Succeeds(1)); // stdout
Expand All @@ -32,11 +33,13 @@ TEST(LlvmLibcIsATTYTest, StdInOutTests) {
}

TEST(LlvmLibcIsATTYTest, BadFdTest) {
errno = 0;
EXPECT_THAT(__llvm_libc::isatty(-1), Fails(EBADF, 0)); // invalid fd
}

TEST(LlvmLibcIsATTYTest, DevTTYTest) {
constexpr const char *TTY_FILE = "/dev/tty";
errno = 0;
int fd = __llvm_libc::open(TTY_FILE, O_RDONLY);
if (fd > 0) {
ASSERT_EQ(errno, 0);
Expand All @@ -47,6 +50,7 @@ TEST(LlvmLibcIsATTYTest, DevTTYTest) {

TEST(LlvmLibcIsATTYTest, FileTest) {
constexpr const char *TEST_FILE = "testdata/isatty.test";
errno = 0;
int fd = __llvm_libc::open(TEST_FILE, O_WRONLY | O_CREAT, S_IRWXU);
ASSERT_EQ(errno, 0);
ASSERT_GT(fd, 0);
Expand Down

0 comments on commit aec239c

Please sign in to comment.