Skip to content

Commit c558c22

Browse files
committed
[llvm-symbolizer] Add legacy aliases -demangle=true and -demangle=false.
This is used in the wild, don't break compatibility for no good reason. https://github.com/google/pprof/blob/master/internal/binutils/addr2liner_llvm.go
1 parent 4963ca4 commit c558c22

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

llvm/test/tools/llvm-symbolizer/demangle.s

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,11 @@ _Z1cv:
3131
# RUN: llvm-addr2line -fCe %t.o 0 \
3232
# RUN: | FileCheck %s --check-prefix=DEMANGLED_FUNCTION_NAME
3333

34+
# pprof passes -demangle=false
35+
# RUN: llvm-symbolizer -demangle=false --obj %t.o 0 \
36+
# RUN: | FileCheck %s --check-prefix=MANGLED_FUNCTION_NAME
37+
# RUN: llvm-symbolizer -demangle=true --obj %t.o 0 \
38+
# RUN: | FileCheck %s --check-prefix=DEMANGLED_FUNCTION_NAME
39+
3440
# MANGLED_FUNCTION_NAME: _Z1cv
3541
# DEMANGLED_FUNCTION_NAME: c()

llvm/tools/llvm-symbolizer/Opts.td

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,6 @@ def : Flag<["-"], "s">, Alias<basenames>, HelpText<"Alias for --basenames">;
6262
// Compatibility aliases for old asan_symbolize.py and sanitizer binaries (before 2020-08).
6363
def : Flag<["--"], "inlining=true">, Alias<inlines>, HelpText<"Alias for --inlines">;
6464
def : Flag<["--"], "inlining=false">, Alias<no_inlines>, HelpText<"Alias for --no-inlines">;
65+
// Compatibility aliases for pprof's symbolizer.
66+
def : Flag<["-"], "demangle=true">, Alias<demangle>, HelpText<"Alias for --demangle">;
67+
def : Flag<["-"], "demangle=false">, Alias<no_demangle>, HelpText<"Alias for --no-demangle">;

0 commit comments

Comments
 (0)