Skip to content

Commit cb82e8e

Browse files
committed
[libc++] Remove workaround for PR28391 (ODR violations with ASAN)
This is not an issue anymore since we don't build the libc++ dylib with C++14 anymore (see https://llvm.org/PR28391) for details. Differential Revision: https://reviews.llvm.org/D102106
1 parent ea68ad6 commit cb82e8e

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

libcxx/utils/libcxx/test/config.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -490,9 +490,6 @@ def add_ubsan():
490490
self.cxx.flags += ['-fsanitize=address']
491491
if llvm_symbolizer is not None:
492492
self.exec_env['ASAN_SYMBOLIZER_PATH'] = llvm_symbolizer
493-
# FIXME: Turn ODR violation back on after PR28391 is resolved
494-
# https://llvm.org/PR28391
495-
self.exec_env['ASAN_OPTIONS'] = 'detect_odr_violation=0'
496493
self.config.available_features.add('asan')
497494
self.config.available_features.add('sanitizer-new-delete')
498495
self.cxx.compile_flags += ['-O1']

0 commit comments

Comments
 (0)