Skip to content

Commit f4d78a5

Browse files
author
Vladislav Vinogradov
committed
[mlir][NFC] Add missing namespace qualifier to ODS generated code
Use `::mlir::Region` inside array ref for `VariadicRegion`. Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D97376
1 parent 0ad86f8 commit f4d78a5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/test/mlir-tblgen/op-decl.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def NS_AOp : NS_Op<"a_op", [IsolatedFromAbove, IsolatedFromAbove]> {
7676
// CHECK: ::mlir::Operation::result_range getODSResults(unsigned index);
7777
// CHECK: ::mlir::Value r();
7878
// CHECK: ::mlir::Region &someRegion();
79-
// CHECK: ::mlir::MutableArrayRef<Region> someRegions();
79+
// CHECK: ::mlir::MutableArrayRef<::mlir::Region> someRegions();
8080
// CHECK: ::mlir::IntegerAttr attr1Attr()
8181
// CHECK: uint32_t attr1();
8282
// CHECK: ::mlir::FloatAttr attr2Attr()

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1014,8 +1014,8 @@ void OpEmitter::genNamedRegionGetters() {
10141014

10151015
// Generate the accessors for a variadic region.
10161016
if (region.isVariadic()) {
1017-
auto *m = opClass.addMethodAndPrune("::mlir::MutableArrayRef<Region>",
1018-
region.name);
1017+
auto *m = opClass.addMethodAndPrune(
1018+
"::mlir::MutableArrayRef<::mlir::Region>", region.name);
10191019
m->body() << formatv(" return (*this)->getRegions().drop_front({0});",
10201020
i);
10211021
continue;

0 commit comments

Comments
 (0)