Skip to content

Commit

Permalink
[Clang][DependencyScanner] Remove secondary actions from -cc1
Browse files Browse the repository at this point in the history
The -arcmt-action= and -objcmt-migrate* actions were being passed to
module builds. This caused these builds to fail, as they are secondary
actions that suppress emitting modules.

Differential Revision: https://reviews.llvm.org/D143040
  • Loading branch information
Bigcheese committed Feb 1, 2023
1 parent 7e566a3 commit ffa2a64
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 0 deletions.
3 changes: 3 additions & 0 deletions clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ ModuleDepCollector::makeInvocationForModuleBuildWithoutOutputs(
CI.getDependencyOutputOpts().Targets.clear();

CI.getFrontendOpts().ProgramAction = frontend::GenerateModule;
CI.getFrontendOpts().ARCMTAction = FrontendOptions::ARCMT_None;
CI.getFrontendOpts().ObjCMTAction = FrontendOptions::ObjCMT_None;
CI.getFrontendOpts().MTMigrateDir.clear();
CI.getLangOpts()->ModuleName = Deps.ID.ModuleName;
CI.getFrontendOpts().IsSystemModule = Deps.IsSystem;

Expand Down
52 changes: 52 additions & 0 deletions clang/test/ClangScanDeps/strip-input-args.m
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
// RUN: rm -rf %t
// RUN: split-file %s %t
// RUN: sed -e "s|DIR|%/t|g" %t/cdb1.json.template > %t/cdb1.json

// RUN: clang-scan-deps -compilation-database %t/cdb1.json -format experimental-full -mode preprocess-dependency-directives > %t/result1.txt

// RUN: FileCheck %s -input-file %t/result1.txt

// Verify that secondary actions get stripped, and that there's a single version
// of module A.

// CHECK: "modules": [
// CHECK-NEXT: {
// CHECK: "command-line": [
// CHECK-NOT: "-arcmt-action=check"
// CHECK-NOT: "-objcmt-migrate-literals"
// CHECK-NOT: "-mt-migrate-directory"
// CHECK: ]
// CHECK: "name": "A"
// CHECK: }
// CHECK-NOT: "name": "A"
// CHECK: "translation-units"

//--- cdb1.json.template
[
{
"directory": "DIR",
"command": "clang -Imodules/A -fmodules -fmodules-cache-path=DIR/module-cache -fimplicit-modules -fimplicit-module-maps -ccc-arcmt-check -fsyntax-only DIR/t1.m",
"file": "DIR/t1.m"
},
{
"directory": "DIR",
"command": "clang -Imodules/A -fmodules -fmodules-cache-path=DIR/module-cache -fimplicit-modules -fimplicit-module-maps -ccc-objcmt-migrate bob -fsyntax-only DIR/t2.m",
"file": "DIR/t2.m"
}
]

//--- modules/A/module.modulemap

module A {
umbrella header "A.h"
}

//--- modules/A/A.h

typedef int A_t;

//--- t1.m
@import A;

//--- t2.m
@import A;

0 comments on commit ffa2a64

Please sign in to comment.