Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function pointers with calling conventions not spaced correctly #34171

Open
smeenai opened this issue Oct 4, 2017 · 1 comment
Open

Function pointers with calling conventions not spaced correctly #34171

smeenai opened this issue Oct 4, 2017 · 1 comment
Labels
bugzilla Issues migrated from bugzilla clang-format

Comments

@smeenai
Copy link
Collaborator

smeenai commented Oct 4, 2017 •
edited
Loading

Bugzilla Link 34823
Version trunk
OS All
CC @compnerd

Extended Description

% echo 'void (__stdcall *f)(void);' | clang-format
void(__stdcall *f)(void);

The space between the type and pointer name gets dropped if the pointer has a calling convention. It works as expected without the calling convention.
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@Ryzee119 Ryzee119 mentioned this issue Jun 15, 2024
Merged
zeux added a commit to zeux/meshoptimizer that referenced this issue Jun 24, 2024
@zeux
Minor formatting changes
f13503c 
meshoptimizer.h is not covered by clang-format and it had a couple cases
where spaces were used for indentation instead of tabs.

allocator.cpp *is* covered by clang-format and it's hitting the bug
llvm/llvm-project#34171; it's probably not
worth trying to work around this for a single file that is basically
never edited, but it's valuable to keep `make format` be a no-op.
@dzhdanNV
Copy link

It's still the issue in 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla clang-format
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smeenai @dzhdanNV