Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clangd] Add CodeAction to swap operands to binary operators #78998

Closed
torshepherd opened this issue Jan 22, 2024 · 1 comment · Fixed by #78999
Closed

[clangd] Add CodeAction to swap operands to binary operators #78998

torshepherd opened this issue Jan 22, 2024 · 1 comment · Fixed by #78999
Labels
clangd enhancement Improving things as opposed to bug fixing, e.g. new or missing feature

Comments

@torshepherd
Copy link
Contributor

Title. Turn:

if (p == nullptr) ...
if (x <= 5) ...

into

if (nullptr == p) ...
if (5 >= x) ...
@EugeneZelenko EugeneZelenko added clangd enhancement Improving things as opposed to bug fixing, e.g. new or missing feature and removed new issue labels Jan 22, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jan 22, 2024

@llvm/issue-subscribers-clangd

Author: Tor Shepherd (torshepherd)

Title. Turn: 
if (p == nullptr) ...
if (x &lt;= 5) ...

into

if (nullptr == p) ...
if (5 &gt;= x) ...

@torshepherd torshepherd mentioned this issue Jan 22, 2024
Merged
5chmidti pushed a commit that referenced this issue Oct 3, 2024
@torshepherd
[clangd] Add CodeAction to swap operands to binary operators (#78999)
81fcdc6 
This MR resolves #78998
xgupta pushed a commit to xgupta/llvm-project that referenced this issue Oct 4, 2024
@torshepherd @xgupta
[clangd] Add CodeAction to swap operands to binary operators (llvm#78999
808ae24 
)

This MR resolves llvm#78998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clangd enhancement Improving things as opposed to bug fixing, e.g. new or missing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[clangd] Add CodeAction to swap operands to binary operators torshepherd/llvm-customizations
3 participants
@EugeneZelenko @torshepherd @llvmbot