-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoopIdiomRecognize] Poison flags stripped even though no transform performed #82337
Labels
llvm:SCEV
Scalar Evolution
Comments
processLoopStoreOfLoopLoad() uses SCEVExpanderCleaner, which removes newly inserted instructions, but does not restore modified flags. |
nikic
added a commit
that referenced
this issue
Feb 20, 2024
nikic
added a commit
to nikic/llvm-project
that referenced
this issue
Feb 20, 2024
SCEVExpanderCleaner will currently remove instructions created by SCEVExpander, but not restore poison generating flags that it may have dropped. As such, running LIR can currently spuriously drop flags without performing any transforms. Fix this by keeping track of original instruction flags in SCEVExpander. Fixes llvm#82337.
nikic
added a commit
to nikic/llvm-project
that referenced
this issue
Feb 21, 2024
SCEVExpanderCleaner will currently remove instructions created by SCEVExpander, but not restore poison generating flags that it may have dropped. As such, running LIR can currently spuriously drop flags without performing any transforms. Fix this by keeping track of original instruction flags in SCEVExpander. Fixes llvm#82337.
nikic
added a commit
that referenced
this issue
Feb 21, 2024
…82362) SCEVExpanderCleaner will currently remove instructions created by SCEVExpander, but not restore poison generating flags that it may have dropped. As such, running LIR can currently spuriously drop flags without performing any transforms. Fix this by keeping track of original instruction flags in SCEVExpander. Fixes #82337.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this example, LIR will remove the nuw/exact flags on
%dist
and%len
, even though it does not actually perform any transform:The text was updated successfully, but these errors were encountered: