[analyzer] Crashes when analyzing a call to a user-defined function named strerror
#88181
Labels
Comments
EugeneZelenko
added
clang:static analyzer
crash
|
@llvm/issue-subscribers-clang-static-analyzer Author: Ilya A. Kriveshko (iillyyaa)
Use of a function named `strerror` in a private namespace causes clang-tidy to crash.
If the function is renamed to anything else (e.g. `strerrorX`) the crash disappears.
Minimal program that shows this issue: #include <string>
namespace other {
std::string strerror(int errnum);
void test() {
(void)strerror(0);
}
} // namespace otherRunning this through clang-tidy in LLVM 18.1.2 leads to: Note that this stack trace was produced when compiling exactly the minimal example in place of the original source that exhibited the issue. However, the same issue is currently also reproducible in clang-tidy (trunk) on godbolt.org: https://godbolt.org/z/93Tqv4n8x As an explanatory aside: our project uses a thread-safe wrapper for |
steakhal
changed the title
strerrorstrerror
steakhal
added a commit
that referenced
this issue
Apr 17, 2024
steakhal
added a commit
to steakhal/llvm-project
that referenced
this issue
Apr 17, 2024
Fixes llvm#88181 (cherry picked from commit e096c14)
tstellar
pushed a commit
to steakhal/llvm-project
that referenced
this issue
Apr 23, 2024
Fixes llvm#88181 (cherry picked from commit e096c14)
NagyDonat
added a commit
to Ericsson/llvm-project
that referenced
this issue
May 16, 2024
This commit deletes the "simple" constructor of `CallDescription` which did not require a `CallDescription::Mode` argument and always used the "wildcard" mode `CDM::Unspecified`. A few months ago, this vague matching mode was used by many checkers, which caused bugs like llvm#81597 and llvm#88181. Since then, my commits improved the available matching modes and ensured that all checkers explicitly specify the right matching mode. After those commits, the only remaining references to the "simple" constructor were some unit tests; this commit updates them to use an explicitly specified matching mode (often `CDM::SimpleFunc`). The mode `CDM::Unspecified` was not deleted in this commit because it's still a reasonable choice in `GenericTaintChecker` and a few unit tests.
NagyDonat
added a commit
that referenced
this issue
May 17, 2024
…92454) This commit deletes the "simple" constructor of `CallDescription` which did not require a `CallDescription::Mode` argument and always used the "wildcard" mode `CDM::Unspecified`. A few months ago, this vague matching mode was used by many checkers, which caused bugs like #81597 and #88181. Since then, my commits improved the available matching modes and ensured that all checkers explicitly specify the right matching mode. After those commits, the only remaining references to the "simple" constructor were some unit tests; this commit updates them to use an explicitly specified matching mode (often `CDM::SimpleFunc`). The mode `CDM::Unspecified` was not deleted in this commit because it's still a reasonable choice in `GenericTaintChecker` and a few unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use of a function named
strerrorin a private namespace causes clang-tidy to crash.If the function is renamed to anything else (e.g.
strerrorX) the crash disappears.Minimal program that shows this issue:
Running this through clang-tidy in LLVM 18.1.2 leads to:
Note that this stack trace was produced when compiling exactly the minimal example in place of the original source that exhibited the issue. However, the same issue is currently also reproducible in clang-tidy (trunk) on godbolt.org:
https://godbolt.org/z/93Tqv4n8x
As an explanatory aside: our project uses a thread-safe wrapper for
strerrorin a custom namespace that is implemented in terms ofstd::generic_category().message(errnum)to appeaseconcurrency-mt-unsafecheck.The text was updated successfully, but these errors were encountered: