[libc] move pthread macros to a dedicated header

[nickdesaulniers]

Forked from #88987 (comment)

The macros defined in libc/include/pthread.h.def should be moved to a corresponding libc/include/llvm-libc-macros/pthreads-macros.h (unless these values are linux specific, in which case perhaps they should go in a newly created libc/include/llvm-libc-macros/linux/pthreads-macros.h).

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Nick Desaulniers (nickdesaulniers)

Forked from https://github.com//pull/88987#discussion_r1567968097

The macros defined in libc/include/pthread.h.def should be moved to a corresponding libc/include/llvm-libc-macros/pthreads-macros.h (unless these values are linux specific, in which case perhaps they should go in a newly created libc/include/llvm-libc-macros/linux/pthreads-macros.h).

[llvmbot]

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Forked from https://github.com//pull/88987#discussion_r1567968097

The macros defined in libc/include/pthread.h.def should be moved to a corresponding libc/include/llvm-libc-macros/pthreads-macros.h (unless these values are linux specific, in which case perhaps they should go in a newly created libc/include/llvm-libc-macros/linux/pthreads-macros.h).

[fabricerenard12]

Hi, if no one is working on this already I'd be glad to do it.

[nickdesaulniers]

You can do it @fabricerenard12 !

So a convention we have throughout most of the codebase is that:

• libc/include/stdbit.h.def doesn't declare any macros, but instead it includes
• libc/include/llvm-libc-macros/stdbit-macros.h

This allows us to simply include include/llvm-libc-macros/stdbit-macros.h to test just the macros separate from the rest of the header. So in this case, the macros defined in libc/include/pthread.h.def should be moved to a new header libc/include/llvm-libc-macros/pthreads-macros.h. Don't forget to update:

• libc/include/CMakeLists.txt
• libc/include/llvm-libc-macros/CMakeLists.txt

[HendrikHuebner]

@fabricerenard12 are you still working on this?