Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang][ExtractAPI] Remove test with system header #65646

Closed
wants to merge 1 commit into from
Closed

[clang][ExtractAPI] Remove test with system header #65646

wants to merge 1 commit into from

Conversation

evelez7
Copy link
Contributor

@evelez7 evelez7 commented Sep 7, 2023 •
edited
Loading

Removes testing that bool is serialized from _Bool in C using stdbool.h. Issue raised here: https://reviews.llvm.org/D158474#inline-1543925

We can still test that bool is properly serialized using the bool.cpp test.

@evelez7 evelez7 requested a review from a team as a code owner September 7, 2023 17:32
daniel-grumberg
daniel-grumberg approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@daniel-grumberg daniel-grumberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evelez7
Copy link
Contributor Author

evelez7 commented Sep 7, 2023

Nevermind: https://reviews.llvm.org/D158474#inline-1544258

@evelez7 evelez7 closed this Sep 7, 2023
@evelez7 evelez7 deleted the extractapi-remove-system-header branch September 7, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-grumberg daniel-grumberg daniel-grumberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evelez7 @daniel-grumberg