-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenMPOpt] Allow indirect calls in AAKernelInfoCallSite #65836
[OpenMPOpt] Allow indirect calls in AAKernelInfoCallSite #65836
Conversation
The Attributor has gained support for indirect calls but it is opt-in. This patch makes AAKernelInfoCallSite able to handle multiple potential callees.
@llvm/pr-subscribers-openmp Changesdiff --git a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp index 63493eb78c451a6..44aed2697842201 100644 --- a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp +++ b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp @@ -3532,6 +3532,10 @@ struct AAKernelInfo : public StateWrapper { using Base = StateWrapper; AAKernelInfo(const IRPosition &IRP, Attributor &A) : Base(IRP) {}
@@ -4797,139 +4801,157 @@ struct AAKernelInfoCallSite : AAKernelInfo {
ChangeStatus updateImpl(Attributor &A) override {
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit
Co-authored-by: Shilei Tian <i@tianshilei.me>
Revert "[OpenMPOpt] Allow indirect calls in AAKernelInfoCallSite (llvm#65836)" Change-Id: I790c81ab7d92e0f828e81535cb131c6c45248138
wq The Attributor has gained support for indirect calls but it is opt-in. This patch makes AAKernelInfoCallSite able to handle multiple potential callees. [LLVM][OpenMPOpt] Fix a crash when associated function is nullptr (llvm#66274) The associated function can be a nullptr if it is an indirect call. This causes a crash in `CheckCallee` which always assumes the callee is a valid pointer. Fix llvm#66904. Change-Id: Ief6ea28456dc5c01709049153fe7e30f6aa4cb29
The Attributor has gained support for indirect calls but it is opt-in. This patch makes AAKernelInfoCallSite able to handle multiple potential callees.
The Attributor has gained support for indirect calls but it is opt-in. This patch makes AAKernelInfoCallSite able to handle multiple potential callees.