Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][DeviceRTL][AMDGPU] Add missing libomptarget build targets #65964

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

mhalk
Copy link
Contributor

@mhalk mhalk commented Sep 11, 2023

Extend CMake variable all_amdgpu_architectures by gfx941 and gfx942.

Extend CMake variable `all_amdgpu_architectures` by gfx941 and gfx942.
@mhalk mhalk added the openmp label Sep 11, 2023
@mhalk mhalk self-assigned this Sep 11, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 11, 2023

@llvm/pr-subscribers-openmp

Changes

Extend CMake variable all_amdgpu_architectures by gfx941 and gfx942.

Full diff: https://github.com/llvm/llvm-project/pull/65964.diff

1 Files Affected:

  • (modified) openmp/libomptarget/DeviceRTL/CMakeLists.txt (+4-3)
diff --git a/openmp/libomptarget/DeviceRTL/CMakeLists.txt b/openmp/libomptarget/DeviceRTL/CMakeLists.txt
index 0cbc6117782a441..fee2414b456a14c 100644
--- a/openmp/libomptarget/DeviceRTL/CMakeLists.txt
+++ b/openmp/libomptarget/DeviceRTL/CMakeLists.txt
@@ -55,9 +55,10 @@ set(include_directory ${devicertl_base_directory}/include)
 set(source_directory ${devicertl_base_directory}/src)
 
 set(all_amdgpu_architectures "gfx700;gfx701;gfx801;gfx803;gfx900;gfx902;gfx906"
-                             "gfx908;gfx90a;gfx90c;gfx940;gfx1010;gfx1030"
-                             "gfx1031;gfx1032;gfx1033;gfx1034;gfx1035;gfx1036"
-                             "gfx1100;gfx1101;gfx1102;gfx1103;gfx1150;gfx1151")
+                             "gfx908;gfx90a;gfx90c;gfx940;gfx941;gfx942;gfx1010"
+                             "gfx1030;gfx1031;gfx1032;gfx1033;gfx1034;gfx1035"
+                             "gfx1036;gfx1100;gfx1101;gfx1102;gfx1103;gfx1150"
+                             "gfx1151")
 set(all_nvptx_architectures "sm_35;sm_37;sm_50;sm_52;sm_53;sm_60;sm_61;sm_62"
                             "sm_70;sm_72;sm_75;sm_80;sm_86;sm_87;sm_89;sm_90")
 set(all_gpu_architectures

Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a better long-term solution to this, as it's quickly going to become a larger burden to build for 50+ architectures as vendors keep making cards. But for now this is the best solution we have.

@mhalk
Copy link
Contributor Author

mhalk commented Sep 11, 2023

Thanks for the additional info @jhuber6 !

@mhalk mhalk merged commit 12ac0f6 into llvm:main Sep 11, 2023
3 checks passed
@mhalk mhalk deleted the fix/add_missing_targets_gfx94x branch September 14, 2023 10:38
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
…lvm#65964)

Extend CMake variable `all_amdgpu_architectures` by `gfx941` and
`gfx942`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants