[PowerPC] Support local-dynamic TLS relocation on AIX #66316
Merged
Commits on Feb 29, 2024
-
-
-
-
-
-
Attempt to address comment: use r4 for LoadOffsetToc
However looks like machine-scheduler is interfering, and still schedule LoadOffsetToc ahead of the .__tls_get_mod call.
-
-
Fixed issues raised by comments and incorporated suggested changes.
(1) Removed TLSLDAIX argument so that duplicated nodes can be eliminated. (2) Try to reuse clobber r4 by moving TLSLDAIX ahead of LoadOffsetToc node. (3) Add FIXME comments. (4) Add test case to show duplicated .__tls_get_mod can be eliminated. Below two cases are not updated yet due to environment issue. I will fix those in next update. Failed Tests: LLVM :: CodeGen/PowerPC/aix-tls-xcoff-reloc-large.ll LLVM :: CodeGen/PowerPC/aix-tls-xcoff-reloc.ll
-
(1) Use GPR3 directly in LoadModuleHandle.
(2) Update comments.
-
-
-
[NFC] Add FIXME to highlight existing issue:
The "_$TLSML" symbol did not lower through getTOCEntry().
-
The "_$TLSML" symbol did not lower through getTOCEntry(). The pseudo node "TLSLDAIX" now takes the _$TLSML GV node, and the ppc-tls-dynamic-call pass is updated to fine tune the relative order between the LoadOffset@toc node and the .__tls_get_mod node.
-
-
-
-
Simplify logic by move the XMC_TC setting for the _$TLSML symbol into…
… getSectionForTOCEntry()
-
-
-
-
-
-
Since `getSectionForExternalReference` explicitly set XCOFF::XTY_SD for the `_$TLSML` symbol reference, and that only CSType `XCOFF::XTY_ER` symbol references are added into `UndefinedCsects`, the checks inside `executePostLayoutBinding` are redundant. Update test case to make sure external reference to the `_$TLSML` symbol is not observed.
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.