[LLParser] Merge xor constantexpr parsing with add/mul/shl/lshr/ashr. #67371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if xor is sticking around or not. I see and/or was already removed. This changes the error messages and makes one error message more accurate.
It should be removed as well at some point. |
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 28, 2023
Local branch amd-gfx 7ca00a9 Merged main:210e8984fe15 into amd-gfx:b56415c184f2 Remote branch main 8c26e47 [LLParser] Merge xor constantexpr parsing with add/mul/shl/lshr/ashr. (llvm#67371)
legrosbuffle
pushed a commit
to legrosbuffle/llvm-project
that referenced
this pull request
Sep 29, 2023
…llvm#67371) Not sure if xor is sticking around or not. I see and/or was already removed. This changes the error messages and makes one error message more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if xor is sticking around or not. I see and/or was already removed.
This changes the error messages and makes one error message more accurate.