[compiler-rt] Fix instrprof-darwin-exports test #67487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test currently misses to filter __mh_execute_header in one case which can cause it to fail.
|
@llvm/pr-subscribers-pgo ChangesThe test currently misses to filter __mh_execute_header in one case which can cause it to fail. Full diff: https://github.com/llvm/llvm-project/pull/67487.diff 1 Files Affected:
diff --git a/compiler-rt/test/profile/instrprof-darwin-exports.c b/compiler-rt/test/profile/instrprof-darwin-exports.c
index 5e5f69b91cb80dd..079d5d28ed24d9b 100644
--- a/compiler-rt/test/profile/instrprof-darwin-exports.c
+++ b/compiler-rt/test/profile/instrprof-darwin-exports.c
@@ -22,7 +22,7 @@
//
// RUN: %clang_pgogen -Werror -o %t.default %s
// RUN: nm -jUg %t.default | grep -v __mh_execute_header > %t.default.exports
-// RUN: nm -jUg %t > %t.clang.exports
+// RUN: nm -jUg %t | grep -v __mh_execute_header > %t.clang.exports
// RUN: diff %t.default.exports %t.clang.exports
// 4) Ditto (3), but for GCOV.
|
jroelofs
approved these changes
Sep 26, 2023
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 28, 2023
Local branch amd-gfx 456d45a Merged main:3bb89b6bfbb5 into amd-gfx:40a7b75c817a Remote branch main 134ae13 [compiler-rt] Fix instrprof-darwin-exports test (llvm#67487)
dtellenbach
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 28, 2023
(cherry picked from commit 134ae13)
legrosbuffle
pushed a commit
to legrosbuffle/llvm-project
that referenced
this pull request
Sep 29, 2023
dtellenbach
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 3, 2023
[compiler-rt] Fix instrprof-darwin-exports test (llvm#67487) (cherry picked from commit 134ae13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test currently misses to filter __mh_execute_header in one case which can cause it to fail.