[OpenMP] Improve omp offload profiler #68016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
jdoerfert
changed the title
jdoerfert
reviewed
Oct 2, 2023
fel-cab
pushed a commit
to fel-cab/llvm-project
that referenced
this pull request
Oct 3, 2023
…mprove LIBOMPTARGET profiling, as it allows to measure more events. It was part of PR llvm#68016
markdewing
reviewed
Oct 6, 2023
openmp/libomptarget/src/private.h
Outdated
| std::string RTM = RegionTypeMsg; \ | ||
| llvm::TimeTraceScope TimeScope(__FUNCTION__, ProfileLocation + RTM) | ||
| // llvm::TimeTraceScope TimeScope(RegionTypeMsg, ProfileLocation + RTM) |
There was a problem hiding this comment.
minor: commented-out code
|
I have prepared a presentation to better explain the proposed changes |
jdoerfert
approved these changes
Dec 21, 2023
…ntime calls and different ones for kernel lunches and memory transfers.
…xtra info in kernels and device
…n that the profile added the colons to make the total more clear in the trace
…it will be a separate PR
…sary for the changes to the llvm/lib/Support/TimeProfiler.cpp, which was removed from this PR
fel-cab
force-pushed
the
improveOmpOffloadProfiler
branch
from
53bcadb
to
d56e4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding information to the LIBOMPTARGET profiler runtime kernel and API calls.
Key changes:
is executing. For example teams requested by the user, size of memory transfers.
to register some important details like key kernel duration
developers.