Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flang][OpenMP] Fix comments that should not be Sentinels on fixed format. #68911

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[Flang][OpenMP] Fix comments that should not be Sentinels on fixed format. #68911

merged 1 commit into from
Oct 30, 2023

Conversation

Z572
Copy link
Contributor

@Z572 Z572 commented Oct 12, 2023

Fixes #68653

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:openmp flang:parser labels Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@Z572 Z572 changed the title [Flang][OpenMP] Fix comments that should not be Sentinels on fixed format. (#68653) [Flang][OpenMP] Fix comments that should not be Sentinels on fixed format. Oct 12, 2023
rofirrim
rofirrim requested changes Oct 12, 2023
View reviewed changes
flang/lib/Parser/prescan.cpp Outdated Show resolved Hide resolved
@Z572 Z572 force-pushed the main branch 2 times, most recently from 1681881 to 954de2c Compare October 13, 2023 07:51
@Z572
Copy link
Contributor Author

Z572 commented Oct 13, 2023

no idea why Lower/OpenMP/parallel-private-clause-fixes.f90 test fail.

@kiranchandramohan
Copy link
Contributor

no idea why Lower/OpenMP/parallel-private-clause-fixes.f90 test fail.

Do you have ef9f617 in your branch from where you made this PR? If not could you rebase?

rofirrim
rofirrim reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@rofirrim rofirrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But let's wait for @klausler in case he has further comments.

flang/test/Parser/OpenMP/sentinels.f Show resolved Hide resolved
flang/lib/Parser/prescan.cpp Outdated Show resolved Hide resolved
@Z572
Copy link
Contributor Author

Z572 commented Oct 20, 2023

ping

@Z572
Copy link
Contributor Author

Z572 commented Oct 28, 2023

ping

@Z572 Z572 merged commit 7de70e0 into llvm:main Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofirrim rofirrim rofirrim requested changes

@klausler klausler klausler approved these changes

@kiranchandramohan kiranchandramohan Awaiting requested review from kiranchandramohan

@luporl luporl Awaiting requested review from luporl

Assignees
No one assigned
Labels
flang:openmp flang:parser flang Flang issues not falling into any other category
Projects
None yet
Milestone
No milestone
5 participants
@Z572 @kiranchandramohan @rofirrim @klausler @llvmbot