-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #41439: Update the documentation with the correct information. #69377
Fix #41439: Update the documentation with the correct information. #69377
Conversation
@llvm/pr-subscribers-clang-tidy Author: None (Da-Viper) ChangesFixes #41439 The documentation is update to say it is allowed to have omitted parameter names if the variable is not used Full diff: https://github.com/llvm/llvm-project/pull/69377.diff 1 Files Affected:
diff --git a/clang-tools-extra/docs/clang-tidy/checks/readability/named-parameter.rst b/clang-tools-extra/docs/clang-tidy/checks/readability/named-parameter.rst
index 8d28c0aa02169a7..7e7099b3df251d1 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/readability/named-parameter.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/readability/named-parameter.rst
@@ -10,7 +10,12 @@ Guide:
https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
-All parameters should be named, with identical names in the declaration and
-implementation.
+A parameter name may be omitted only if the parameter is not used in the
+function's definition.
+
+.. code-block:: c++
+int doingSomething(int a, int b, int) { // Ok: the third paramet is not used
+ return a + b;
+}
Corresponding cpplint.py check name: `readability/function`.
|
clang-tools-extra/docs/clang-tidy/checks/readability/named-parameter.rst
Show resolved
Hide resolved
clang-tools-extra/docs/clang-tidy/checks/readability/named-parameter.rst
Outdated
Show resolved
Hide resolved
llvm#70209) …to also take into account the op itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Unless you want it merged as "57949090+Da-Viper@users.noreply.github.com", please update your github config.
Fixes #41439
The documentation is update to say it is allowed to have omitted parameter names if the variable is not used