[TableGen][NFC] Add record kind to Record class
#69919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangpc-pp
requested review from
nhaehnle,
fpetrogalli,
Artem-B and
Paul-C-Anagnostopoulos
and removed request for
nhaehnle
fpetrogalli
reviewed
Oct 23, 2023
Artem-B
approved these changes
Oct 23, 2023
enum `RecordKind` is added to indicate the kind of Record (which can be a normal record, anonymous record, class or multiclass). Some arguments like `IsMC` and `IsDefm` are removed since we can get the information from `RecordKind`.
Apply renaming suggestion and remove argument comments
wangpc-pp
force-pushed
the
main-tablegen-record-is-multiclass
branch
from
dd84a16
to
d801282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enum
RecordKindis added to indicate the kind of Record (whichcan be a normal record definition, anonymous record definition,
class or multiclass).
Some arguments like
IsMCandIsDefmare removed since we canget the information from
RecordKind.